From aa1e2ca57866811894ae28773193a3a85fa36040 Mon Sep 17 00:00:00 2001 From: Bart Stefanski Date: Fri, 21 Apr 2023 13:01:11 +0200 Subject: [PATCH] chore: fix formatting in ci/cd pipelines --- .github/workflows/bundle.yml | 68 ++++++++++---------------------- .github/workflows/check.yml | 15 +++---- .github/workflows/cr.yml | 12 +++--- .github/workflows/playwright.yml | 38 +++++++++--------- 4 files changed, 53 insertions(+), 80 deletions(-) diff --git a/.github/workflows/bundle.yml b/.github/workflows/bundle.yml index 08b7f33..4af39fe 100644 --- a/.github/workflows/bundle.yml +++ b/.github/workflows/bundle.yml @@ -1,17 +1,13 @@ -name: "Next.js Bundle Analysis" - +name: Next.js Bundle Analysis on: pull_request: branches: - main - staging - workflow_dispatch: - + workflow_dispatch: null defaults: run: - # change this if your nextjs app does not live at the root of the repo working-directory: ./ - jobs: analyze: runs-on: ubuntu-latest @@ -21,14 +17,12 @@ jobs: steps: - uses: actions/checkout@v3 - run: echo "node_version=$(cat .github/nodejs.version)" >> $GITHUB_ENV - - name: use node ${{ env.node_version }} + - name: "use node ${{ env.node_version }}" uses: actions/setup-node@v3 with: - node-version: ${{ env.node_version }} - + node-version: "${{ env.node_version }}" - name: Install dependencies run: yarn install --frozen-lockfile - - name: Restore next build uses: actions/cache@v3 id: restore-build-cache @@ -36,82 +30,60 @@ jobs: cache-name: cache-next-build with: path: .next/cache - # change this if you prefer a more strict cache - key: ${{ runner.os }}-build-${{ env.cache-name }} - + key: "${{ runner.os }}-build-${{ env.cache-name }}" - name: Build next.js app env: SKIP_BUILD_PRODUCT_REDIRECTS: 1 - # change this if your site requires a custom build command run: yarn build - - # Here's the first place where next-bundle-analysis' own script is used - # This step pulls the raw bundle stats for the current bundle - name: Analyze bundle run: npx -p nextjs-bundle-analysis report - - name: Upload bundle uses: actions/upload-artifact@v3 with: name: bundle path: .next/analyze/__bundle_analysis.json - - name: Download base branch bundle stats uses: dawidd6/action-download-artifact@v2 if: success() && github.event.number with: workflow: nextjs_bundle_analysis.yml - branch: ${{ github.event.pull_request.base.ref }} + branch: "${{ github.event.pull_request.base.ref }}" path: .next/analyze/base - - # And here's the second place - this runs after we have both the current and - # base branch bundle stats, and will compare them to determine what changed. - # There are two configurable arguments that come from package.json: - # - # - budget: optional, set a budget (bytes) against which size changes are measured - # it's set to 350kb here by default, as informed by the following piece: - # https://infrequently.org/2021/03/the-performance-inequality-gap/ - # - # - red-status-percentage: sets the percent size increase where you get a red - # status indicator, defaults to 20% - # - # Either of these arguments can be changed or removed by editing the `nextBundleAnalysis` - # entry in your package.json file. - name: Compare with base branch bundle if: success() && github.event.number run: ls -laR .next/analyze/base && npx -p nextjs-bundle-analysis compare - - name: Get comment body id: get-comment-body if: success() && github.event.number uses: actions/github-script@v6 with: result-encoding: string - script: | + script: > const fs = require('fs') - const comment = fs.readFileSync('.next/analyze/__bundle_analysis_comment.txt', 'utf8') - core.setOutput('body', comment) + const comment = + fs.readFileSync('.next/analyze/__bundle_analysis_comment.txt', + 'utf8') + + core.setOutput('body', comment) - name: Find Comment uses: peter-evans/find-comment@v2 if: success() && github.event.number id: fc with: - issue-number: ${{ github.event.number }} - body-includes: "" - + issue-number: "${{ github.event.number }}" + body-includes: - name: Create Comment uses: peter-evans/create-or-update-comment@v2 if: success() && github.event.number && steps.fc.outputs.comment-id == 0 with: - issue-number: ${{ github.event.number }} - body: ${{ steps.get-comment-body.outputs.body }} - + issue-number: "${{ github.event.number }}" + body: "${{ steps.get-comment-body.outputs.body }}" - name: Update Comment uses: peter-evans/create-or-update-comment@v2 if: success() && github.event.number && steps.fc.outputs.comment-id != 0 with: - issue-number: ${{ github.event.number }} - body: ${{ steps.get-comment-body.outputs.body }} - comment-id: ${{ steps.fc.outputs.comment-id }} - edit-mode: replace \ No newline at end of file + issue-number: "${{ github.event.number }}" + body: "${{ steps.get-comment-body.outputs.body }}" + comment-id: "${{ steps.fc.outputs.comment-id }}" + edit-mode: replace diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 2186a5c..b431491 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -1,8 +1,8 @@ name: Check on: - pull_request: - workflow_dispatch: + pull_request: null + workflow_dispatch: null jobs: check: @@ -11,10 +11,10 @@ jobs: steps: - uses: actions/checkout@v3 - run: echo "node_version=$(cat .github/nodejs.version)" >> $GITHUB_ENV - - name: use node ${{ env.node_version }} + - name: "use node ${{ env.node_version }}" uses: actions/setup-node@v3 with: - node-version: ${{ env.node_version }} + node-version: "${{ env.node_version }}" - name: Install dependencies run: yarn install --frozen-lockfile - name: Lint check @@ -26,6 +26,7 @@ jobs: - name: Smoke & Acceptance tests run: - yarn build-storybook --quiet - - npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \ - "npx http-server storybook-static --port 6006 --silent" \ - "npx wait-on tcp:6006 && yarn test-storybook" + - >- + npx concurrently -k -s first -n "SB,TEST" -c "magenta,blue" \ "npx + http-server storybook-static --port 6006 --silent" \ "npx wait-on + tcp:6006 && yarn test-storybook" diff --git a/.github/workflows/cr.yml b/.github/workflows/cr.yml index 2074f67..e51fac2 100644 --- a/.github/workflows/cr.yml +++ b/.github/workflows/cr.yml @@ -1,18 +1,18 @@ name: Code Review - permissions: contents: read pull-requests: write - on: pull_request: - types: [opened, reopened, synchronize] - + types: + - opened + - reopened + - synchronize jobs: test: runs-on: ubuntu-latest steps: - uses: anc95/ChatGPT-CodeReview@main env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }} + GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}" + OPENAI_API_KEY: "${{ secrets.OPENAI_API_KEY }}" diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml index 1e10599..142bfd1 100644 --- a/.github/workflows/playwright.yml +++ b/.github/workflows/playwright.yml @@ -1,11 +1,11 @@ name: Playwright Tests - on: push: - branches: [ main, master ] - pull_request: - workflow_dispatch: - + branches: + - main + - master + pull_request: null + workflow_dispatch: null jobs: test: timeout-minutes: 60 @@ -13,19 +13,19 @@ jobs: steps: - uses: actions/checkout@v3 - run: echo "node_version=$(cat .github/nodejs.version)" >> $GITHUB_ENV - - name: use node ${{ env.node_version }} + - name: "use node ${{ env.node_version }}" uses: actions/setup-node@v3 with: - node-version: ${{ env.node_version }} - - name: Install dependencies - run: yarn install --frozen-lockfile - - name: Install Playwright Browsers - run: yarn playwright install --with-deps - - name: Run Playwright tests - run: yarn playwright test - - uses: actions/upload-artifact@v3 - if: always() - with: - name: playwright-report - path: playwright-report/ - retention-days: 30 + node-version: "${{ env.node_version }}" + - name: Install dependencies + run: yarn install --frozen-lockfile + - name: Install Playwright Browsers + run: yarn playwright install --with-deps + - name: Run Playwright tests + run: yarn playwright test + - uses: actions/upload-artifact@v3 + if: always() + with: + name: playwright-report + path: playwright-report/ + retention-days: 30